-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add simulation support for uipath debug command #1117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+608
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd28996 to
29c1016
Compare
akshaylive
approved these changes
Jan 21, 2026
Collaborator
akshaylive
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
The test_debug_with_simulation_file_sets_context test was failing on Windows because load_simulation_config() uses Path.cwd() to locate simulation.json, which wasn't reliably pointing to the isolated filesystem directory in async contexts on Windows. Added a Path.cwd() patch to explicitly ensure it returns the correct directory, consistent with how the unit tests already handle this scenario. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Changed test_debug_with_simulation_file_sets_context to mock load_simulation_config directly rather than trying to patch Path.cwd(). This approach is more robust and avoids filesystem-related issues in async contexts on Windows. The test now directly returns a MockingContext from load_simulation_config, ensuring consistent behavior across platforms. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
- Added MockingStrategyType import and used enum instead of strings - Added isinstance type assertions for union types - Removed unused type: ignore comment in cli_dev.py All mypy errors resolved, tests still pass. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
The type ignore comment is needed in CI environment where uipath.dev module doesn't have type stubs. Locally it may appear unused but it's required for the CI pipeline to pass. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Moved the type: ignore[import-untyped] comment from the imported name to the import statement line for proper mypy recognition in CI. Note: This will show as "unused-ignore" locally where uipath.dev has py.typed marker, but is required in CI where it doesn't. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Ruff detected unused variable assignments in three test functions. Removed the assignments as the result value is not checked in these tests. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Applied ruff formatter to make code more compact and consistent with project formatting standards. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
778b5cc to
649249c
Compare
Bumped package version from 2.5.29 to 2.5.30 and updated uv.lock. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build:dev
Create a dev build from the pr
test:uipath-langchain
Triggers tests in the uipath-langchain-python repository
test:uipath-llamaindex
Triggers tests in the uipath-llamaindex-python repository
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development Package
uipath pack --nolockto get the latest dev build from this PR (requires version range).